Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return tagged metrics registry from metrics.FromContext call. #122

Merged
merged 1 commit into from
Nov 10, 2018
Merged

Return tagged metrics registry from metrics.FromContext call. #122

merged 1 commit into from
Nov 10, 2018

Conversation

jamesross3
Copy link
Contributor

@jamesross3 jamesross3 commented Nov 9, 2018 •
edited by nmiyake
Loading

@bmoylan

This change is Reviewable

bmoylan
bmoylan approved these changes Nov 9, 2018
View reviewed changes
Copy link
Contributor

@bmoylan bmoylan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@bmoylan bmoylan merged commit b5d51c0 into palantir:master Nov 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmoylan bmoylan bmoylan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesross3 @bmoylan