Add retry package #127
Add retry package #127
Conversation
| } | ||
|
|
||
| const ( | ||
| defaultMaxAttempts = 0 // Infinite retries. |
There was a problem hiding this comment.
I do not like this default value (it blocks forever), but worried that changing it would be a break when we have internal consumers move to this import.
There was a problem hiding this comment.
Some minor feedback on documentation, but content looks good. Feel free to merge once comment issues are addressed.
Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @bmoylan)
retry/retry.go, line 87 at r1 (raw file):
} // Retrier allows to control retry loop.
Let's rephrase to correct grammar ("Retrier allows controlling a retry loop." or something else equivalent).
retry/retry.go, line 90 at r1 (raw file):
// // Note that retry loop can be often replaced with simpler and less error-prone Do() function. //
Remove empty comment line
retry/retry.go, line 189 at r1 (raw file):
Previously, bmoylan (Brad Moylan) wrote…
I do not like this default value (it blocks forever), but worried that changing it would be a break when we have internal consumers move to this import.
Yeah understand the downside, but I don't think this is unreasonable as a default and agree with the backcompat concerns.
There was a problem hiding this comment.
Reviewable status: 1 of 2 files reviewed, 2 unresolved discussions (waiting on @nmiyake)
retry/retry.go, line 87 at r1 (raw file):
Previously, nmiyake (Nick Miyake) wrote…
Let's rephrase to correct grammar ("Retrier allows controlling a retry loop." or something else equivalent).
Done.
retry/retry.go, line 90 at r1 (raw file):
Previously, nmiyake (Nick Miyake) wrote…
Remove empty comment line
Done.
This change is