Add bytesbuffers package #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmoylan
force-pushed
the
bm/bytesbuffers
branch
3 times, most recently
from
7f4aa24 to
c0ee0b1
Compare
nmiyake
approved these changes
Dec 3, 2018
There was a problem hiding this comment.
Content looks good! It would be nice to have some documentation (godoc or otherwise) that provides a bit more of a high-level view of when one might want to use the bytesbuffer package -- I actually don't know myself, and being able to figure that out would be nice :)
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
bmoylan
force-pushed
the
bm/bytesbuffers
branch
from
c0ee0b1 to
8df2f23
Compare
|
@nmiyake I added an example - do you think that is demonstrative enough? |
|
Yes, that is much more helpful -- thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is