Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add boolean package #138

Closed
wants to merge 1 commit into from
Closed

Add boolean package #138

wants to merge 1 commit into from

Conversation

bmoylan
Copy link
Contributor

@bmoylan bmoylan commented Jan 3, 2019 •
edited by nmiyake
Loading

Similar motivations to #137. map[bool]bool is not a valid target for encoding/json, but it is valid in conjure.

This change is Reviewable

@bmoylan bmoylan requested a review from nmiyake January 3, 2019 05:52
nmiyake
nmiyake requested changes Jan 10, 2019
View reviewed changes
Copy link
Contributor

@nmiyake nmiyake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed in person, but don't think that we need to create this as a new package -- if we're doing this just for serde, we can generate this type as part of codegen rather than defining it externally.

@bmoylan bmoylan closed this Jan 10, 2019
@bmoylan bmoylan deleted the bm/boolean branch January 10, 2019 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmiyake nmiyake nmiyake requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bmoylan @nmiyake