break: refreshable/v2 with Generic type handling #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmoylan
force-pushed
the
bm/refreshable-v2
branch
from
3cfdc4c to
64aa0ff
Compare
bmoylan
force-pushed
the
bm/refreshable-v2
branch
from
89c7597 to
6fc9aa0
Compare
ravi-braj
reviewed
Aug 1, 2023
bwaldrep
reviewed
Aug 3, 2023
refreshable/async.go
Outdated
Comment on lines
40
to
41
| r.cancel() | ||
| r.in.Update(val) |
ravi-braj
reviewed
Aug 7, 2023
refreshable/async.go
Outdated
| // NewFromTickerFunc returns a Ready Refreshable populated by the result of the provider called each interval. | ||
| // If the providers bool return is false, the value is ignored. | ||
| // The result's ReadyC channel is closed when a new value is populated. | ||
| func NewFromTickerFunc[T any](interval time.Duration, provider func() (T, bool)) (Ready[T], UnsubscribeFunc) { |
There was a problem hiding this comment.
Can we pass context into the provider function so that clients can make use of it (e.g. for logging unexpected behaviour)
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is