Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make stacked bar labels disappear #3227

Merged
merged 1 commit into from
Feb 10, 2017
Merged

Make stacked bar labels disappear #3227

merged 1 commit into from
Feb 10, 2017

Conversation

CalvinFernandez
Copy link
Contributor

@CalvinFernandez CalvinFernandez commented Feb 9, 2017

closes #3217

package.json Outdated
"start:watch-quicktests": "grunt watch-quicktests",
"start:watch-tsc": "tsc -w -p test/",
"dev:server": "./node_modules/webpack-dev-server/bin/webpack-dev-server.js",
"start": "npm-run-all -p watch:watch-tsc watch:watch-quicktests dev:server",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah sorry i screwed this up; fixed it in #3225 , that version look good?

@blueprint-bot
Copy link

Make stacked bar labels disappear

Demo: quicktests | fiddle

@hellochar
Copy link
Contributor

Funnily enough it looks like there's now times when the sum doesn't show but the individual labels do:

https://131-16149854-gh.circle-artifacts.com/0/home/ubuntu/plottable/quicktests/dev/index.html#basic/negative_stacked_bar

but it solves the original issue regardless

@hellochar hellochar merged commit 0a6c1c2 into develop Feb 10, 2017
@hellochar hellochar deleted the stackedBarLabel branch February 10, 2017 12:32
@adidahiya
Copy link
Contributor

@hellochar I believe what you're seeing there is #3193?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Summed bar labels are inconsistent with regular bar labels
4 participants