-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add note to README about double quoted/plain YAML string escape characters #273
Conversation
While including the note here works, many other predicates also use regular expressions. Maybe it would be beneficial to instead add a section like That would give space to be more expansive and add other notes in the future. For example, I just checked and single quoted strings are also valid and don't need escaping. |
That's a great idea. I'll add the section now. I'd be worried users might miss it when looking up a single regex based rule in the examples — what do you think of adding a note to |
The inline comment format isn't great for adding lots of information about each property and I'd be worried about duplication, but I think a line similar to |
README.md
Outdated
@@ -61,6 +61,23 @@ Consider the following example, which allows changes to certain paths without | |||
review, but all other changes require review from the `palantir/devtools`. | |||
Any member of the `palantir` organization can also disapprove changes. | |||
|
|||
#### Notes on YAML Syntax |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd place this after the sample YAML block and before the Remote Policy Configuration
section. Right now, the previous text says "Consider the following example" but then this section appears before the example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, good catch
Due to the way yaml is decoded,
\
characters must be escaped when used in strings with double quotes, but should not be escaped in plain style strings without quotes.