Improve details UI for some predicates #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Replace "from branches" with "source branches" to make the resulting sentence less awkward * Add padding to condition maps and rephrase the changed files condition to separate the top-level condition phrase from the sub-phrases in the map * Add a special case for predicates that have no values to avoid rendering an empty list. I don't think it is necessary to show the condition details when there are no values to compare with.
asvoboda
approved these changes
Apr 30, 2022
yiweny
approved these changes
May 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are some minor adjustments that came up in testing:
[no {{.ValuePhrase}}]as the only list element when there are no values, but I thought that could potentially get confused with actual values.