fix ignore edited comments bug #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluekeyes
approved these changes
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I incorrectly assumed that github would always set updatedAt and submittedAt to be the same upon review comment creation, but apparently that isn't so and it just bit us. Same for createdAt and updatedAt for issue comments.
I was able to easily switch out updatedAt for lastEditedAt and it seems to work well. lastEditedAt is just always null until it is actually edited which makes it much easier to discern programmatically. probably should have went with this from the beginning, but who knew?
at least this bug, although annoying, wasn't broken in the other direction by incorrectly counting edited approvals but instead only intermittently not counting appropriate approvals when the ignore option is enabled.