Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSH signatures support #504

Merged
merged 3 commits into from
Nov 30, 2022
Merged

SSH signatures support #504

merged 3 commits into from
Nov 30, 2022

Conversation

fpoussin
Copy link
Contributor

Hi,

SSH signed commits are currently ignored because the field type was unknown.

This PR adds basic support for it.

@palantirtech
Copy link
Member

Thanks for your interest in palantir/policy-bot, @fpoussin! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

Copy link
Member

@bluekeyes bluekeyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks good for the has_valid_signatures and has_valid_signatures_by predicates. As a follow-up, we should probably add a key_fingerprints property to the has_valid_signatures_by_keys predicate, but I think this is fine to merge for partial SSH support.

@bluekeyes bluekeyes merged commit 07b7361 into palantir:develop Nov 30, 2022
@fpoussin fpoussin deleted the ssh-signatures branch December 1, 2022 09:17
@bluekeyes
Copy link
Member

Hey @fpoussin, it turns out this is incompatible with GitHub Enterprise 3.6 and earlier, which do not support SSH signature. Running the GraphQL query fails with the error: No such type SshSignature, so it can't be a fragment condition

I'm going to see if there's a way to enable the feature only when the target GitHub instance supports it, but I might have to temporarily revert this PR until GitHub Enterprise 3.7 is more widely deployed (probably early in 2023.)

bluekeyes added a commit that referenced this pull request Dec 1, 2022
@fpoussin fpoussin restored the ssh-signatures branch March 21, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants