Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide skipped rules by default in the UI #536

Merged
merged 1 commit into from
Feb 16, 2023
Merged

Hide skipped rules by default in the UI #536

merged 1 commit into from
Feb 16, 2023

Conversation

kmark
Copy link
Contributor

@kmark kmark commented Feb 16, 2023 •
edited by bluekeyes
Loading

When browsing the UI, you’re usually only concerned with the policy rules that actually applied to the specific pull request. This PR changes the “Hide skipped rules” toggle to be on by default.

Fixes #395.

@kmark kmark added enhancement New feature or request javascript Pull requests that update Javascript code labels Feb 16, 2023
@kmark kmark marked this pull request as ready for review February 16, 2023 22:10
@kmark kmark requested a review from bluekeyes February 16, 2023 22:10
bluekeyes
bluekeyes approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@bluekeyes bluekeyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! In my test with a small-ish policy (10 rules), I didn't notice any flash of skipped rules on load and this otherwise worked as expected.

@bluekeyes bluekeyes merged commit 41da81c into develop Feb 16, 2023
@bluekeyes bluekeyes deleted the kmark/filter-by-default branch February 16, 2023 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluekeyes bluekeyes bluekeyes approved these changes

@ericanderson ericanderson ericanderson approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request javascript Pull requests that update Javascript code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow “Hide Skipped Rules” to default to enabled
3 participants
@kmark @ericanderson @bluekeyes