Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: for linux/arm64 platform #556

Merged
merged 1 commit into from
Apr 5, 2023
Merged

build: for linux/arm64 platform #556

merged 1 commit into from
Apr 5, 2023

Conversation

ab77
Copy link
Contributor

@ab77 ab77 commented Apr 3, 2023

Hi folks, hopefully it's as simple as that...

@palantirtech
Copy link
Member

Thanks for your interest in palantir/policy-bot, @ab77! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@ab77 ab77 changed the title build: build for linux/arm64 platform build: for linux/arm64 platform Apr 3, 2023
@bluekeyes
Copy link
Member

Thanks! I think this will do the right thing for the distribution, but I'll have to check if it will also build a linux/arm64 container, or if we need some extra configuration for that.

Copy link
Member

@bluekeyes bluekeyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After following up with internal teams, it looks like our build tool doesn't have full support for multi-architecture containers yet - I filed #558 to track fixing this. Until then, you may need to build your own container using the distribution (which should have both platform binaries once this merges.)

@bluekeyes bluekeyes merged commit 9a4e4e6 into palantir:develop Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants