publish snapshot docker images #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asvoboda
reviewed
Oct 12, 2018
.circleci/config.yml
Outdated
| if [[ -n "${CIRCLE_TAG}" ]] ; then | ||
| docker login -u "${DOCKERHUB_USERNAME}" -p "${DOCKERHUB_PASSWORD}" | ||
| ./godelw docker push | ||
| ./godelw docker push --tags=latest |
There was a problem hiding this comment.
Will this publish both a version and a latest tag? I think we should be doing both, not just latest.
There was a problem hiding this comment.
the new commit fixes this. i misunderstood the value in tags. its supposed to be the key in the tag-templates object: https://github.com/palantir/distgo/blob/master/distgo/config/internal/v0/configdocker.go#L89
bluekeyes
reviewed
Oct 12, 2018
.circleci/config.yml
Outdated
| @@ -87,9 +87,13 @@ jobs: | |||
| - deploy: | |||
| name: Publish | |||
| command: | | |||
| if [[ "${CIRCLE_BRANCH}" == "develop" ]]; then | |||
| docker login -u "${DOCKERHUB_USERNAME}" -p "${DOCKERHUB_PASSWORD}" | |||
| ./godelw docker push --tags=snapshot,version | |||
There was a problem hiding this comment.
I think we want to publish only snapshot in this case, to avoid polluting DockerHub with individually tagged development versions.
bluekeyes
approved these changes
Oct 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
discussed via slack. merging.