-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Option to not post failure status to github when there is no successful policy #711
Add Option to not post failure status to github when there is no successful policy #711
Conversation
Thanks for your interest in palantir/policy-bot, @RoryDoherty! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
I also think the settings in config could be used to implement this: #387 |
Thanks for your contribution! Could you please recreate this as two PRs, one that adds the equality operator and one for the status changes? The equality operator seems straightforward and should be easy to merge, while the status behavior is something I'd like to think about more. While the code change is minimal, it adds some new concepts to Policy Bot that deserve consideration. |
14959a4
to
6a6d063
Compare
@bluekeyes thanks for the feedback, I've updated this PR so that it is just the option to not set failure status checks and opened this PR #712 with the changes for adding the equals operator for file modifications |
@bluekeyes would you be able to take a look at this PR anytime soon? |
Sorry about the delay getting back to this. As I mentioned on the linked issue, I think this feature is something we can add with two changes:
|
Unfortunately the changes you've suggested would make this feature unusable for us
|
This should address the following issue:
#709