Add dismissed state #866
Merged
Add dismissed state #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluekeyes
reviewed
Oct 23, 2024
| @@ -88,6 +88,9 @@ func (h *PullRequestReview) Handle(ctx context.Context, eventType, deliveryID st | |||
|
|
|||
| func (h *PullRequestReview) affectsApproval(reviewState pull.ReviewState, config *policy.Config) bool { | |||
| states := make(map[pull.ReviewState]struct{}) | |||
| // Include dismissed state | |||
There was a problem hiding this comment.
If we're going to comment here, let's explain why we need to include the dismissed state, maybe something like:
Always process events for dismissed reviews because they can revert the overall approval or disapproval to a previous state
bluekeyes
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we skipping the check if the state was dismissed but after adding dismissed as one of the base states it will rerun the policy if we receive that event.