Skip to content

PR: Migrate package to use asyncio, remove Python 2.7 support #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from

Conversation

andfoy
Copy link

@andfoy andfoy commented May 22, 2020

This PR enables this package to use asyncio constructs by default, all the functions were migrated to use async/await syntax and ThreadPoolExecutor was removed and replaced by asyncio.tasks

@poppyschmo
Copy link

poppyschmo commented Jun 30, 2020

@andfoy

You beat me to it! If you catch any grief over the breaking change, it might be worth considering an alternate layout with all the asyncio analogs couched in a subpackage. Hope this PR gains some traction.

@andfoy
Copy link
Author

andfoy commented Jul 9, 2020

Hi @poppyschmo, thanks for your input on this one, right now we're stuck until @ccordoba12 obtains write permissions on this repo

@ccordoba12
Copy link
Contributor

ccordoba12 commented Aug 4, 2020

@uschi2000, I forgot to mention we have here the same problem we had on python-language-server. So could you remove the Required checks on this repo so we can migrate our tests to Github Actions?

@ccordoba12
Copy link
Contributor

ccordoba12 commented Aug 7, 2020

Pinging @uschi2000 about this one again. Sorry to bother you again, please see my comment above. That's the last blocker before we can move to Python 3 and better maintain this project.

@uschi2000
Copy link

@delta003 @jroitgrund could you please take care of the python-language-server CI setup, please?

@delta003
Copy link
Contributor

delta003 commented Aug 9, 2020

@ccordoba12 Removed required

@ccordoba12
Copy link
Contributor

@delta003, thanks a lot for your help!

@delta003 delta003 mentioned this pull request Sep 7, 2020
@delta003
Copy link
Contributor

delta003 commented Sep 8, 2020

@andfoy I can't push to your fork to fix these tests, it should be quick, can you fix it?

@andfoy
Copy link
Author

andfoy commented Sep 8, 2020

Hi @delta003, this PR brakes compatibility with the python-language-server, since we don't have a PR ready there. I don't know what @ccordoba12 thinks about creating a release as the last version that supports python 2.7 and include this one on the next one

@ccordoba12
Copy link
Contributor

I agree. We need to leave this one open until a PR that uses asyncio is ready on python-language-server.

@rchl
Copy link

rchl commented Sep 12, 2020

FYI: asyncio was introduced in v3.4 so this will not only break compatibility with PY2 by also <3.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants