Skip to content

Conversation

ccordoba12
Copy link
Contributor

@ccordoba12 ccordoba12 commented Nov 17, 2019

  • Pylint generates too much warnings without a configuration file. Users that rely on it probably know this, so it's better to let them enable the plugin in an opt-in manner.
  • This follows the example set by the flake8 plugin too.

- Pylint generates too much warnings without a configuration file. Users
that rely on Pylint probably know this so it's better to let them enable
the plugin in an opt-in manner.
- This follows the example set by the flake8 plugin too.
@ccordoba12 ccordoba12 added this to the 0.31.0 milestone Nov 17, 2019
@ccordoba12 ccordoba12 merged commit 45702ec into palantir:develop Nov 17, 2019
@ccordoba12 ccordoba12 deleted the deactivate-pylint branch November 17, 2019 23:40
mpanarin added a commit to mpanarin/lsp-mode that referenced this pull request Nov 18, 2019
yyoncho pushed a commit to emacs-lsp/lsp-mode that referenced this pull request Nov 18, 2019
@zewa666
Copy link

zewa666 commented Nov 20, 2019

meh ... would have been nice if the release notes had pointed out this breaking change @ccordoba12. E.g like here. I know its still pre v1 but perhaps something similar could be adopted so that it's immediately clear for consumers that something needs the attention.

@ccordoba12
Copy link
Contributor Author

Release notes are posted in the Releases page, not in that file.

@zewa666
Copy link

zewa666 commented Nov 20, 2019

True, I just meant that the releases page entry could highlight breaking changes specifically as they might fall through otherwise. The link was just meant to show a sample, e.g a separate section per Release notes

@AndreaOrru
Copy link

AndreaOrru commented May 4, 2020

I found that Pylint may still be run by flycheck as the next checker in chain even when you use flake8.

I solved it by doing:

(add-to-list 'flycheck-disabled-checkers 'python-pylint)

polyzen added a commit to polyzen/dotfiles that referenced this pull request Aug 31, 2020
pyls has it disabled by default for being noisy[0], but I have pylint
disabled globally[1] so it will only be used when a project has a config
file for it.

[0]: palantir/python-language-server#698
[1]: https://gitlab.com/polyzen/dotfiles/-/commit/3a0f7babd6ca0a7f63d2ad1afcab34122af9568b
polyzen added a commit to polyzen/dotfiles that referenced this pull request Sep 1, 2020
pyls has it disabled by default for being noisy[0], but I have pylint
disabled globally[1] so it will only be used when a project has a config
file for it.

[0]: palantir/python-language-server#698
[1]: https://gitlab.com/polyzen/dotfiles/-/commit/3a0f7babd6ca0a7f63d2ad1afcab34122af9568b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants