Unset the JDK-11 CompileCommand override for bundled JDKS #1519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The config option is only necessary for outdated JDKs with a known bug, thus does not impact products which are shipped with bundled JDKs.
Generate changelog in
|
schlosna
approved these changes
Sep 12, 2023
| @@ -168,9 +168,10 @@ static void action(Params params) { | |||
| .addAllJvmOpts(avxOptions) | |||
| .addAllJvmOpts(params.getAddJava8GcLogging().get() ? java8gcLoggingOptions : ImmutableList.of()) | |||
| // Java 11.0.16 introduced a potential memory leak issues when using the C2 | |||
| // compiler | |||
| // compiler, resolved in 11.0.16.1 | |||
There was a problem hiding this comment.
JDK-8291665 for future reference if needed
Comment on lines
172
to
176
| .addAllJvmOpts( | ||
| javaVersion.compareTo(JavaVersion.toVersion("11")) == 0 | ||
| && !params.getBundledJdks().get() | ||
| ? jdk11DisableC2Compile | ||
| : ImmutableList.of()) |
There was a problem hiding this comment.
I'm fine with PR as it is now, but wondering if we should completely remove the compile command even on JDK 11 as anything picking up new sls-packaging release would have dependency on fixed JDKs at this point.
Suggested change
| .addAllJvmOpts( | |
| javaVersion.compareTo(JavaVersion.toVersion("11")) == 0 | |
| && !params.getBundledJdks().get() | |
| ? jdk11DisableC2Compile | |
| : ImmutableList.of()) |
There was a problem hiding this comment.
The failure mode is a potentially old depot, however it is unlikely
bulldozer-bot
bot
deleted the
ckozak/unset_jdk11_compilecommand_for_bundled_jdks
branch
|
Released 7.40.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The config option is only necessary for outdated JDKs with a known bug, thus does not impact products which are shipped with bundled JDKs.
==COMMIT_MSG==
Unset the JDK-11 CompileCommand override for bundled JDKS
==COMMIT_MSG==