Resync to latest SPARK-18364 #154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ash211
force-pushed
the
resync-to-spark-18364
branch
from
db9e5f8 to
82b08bf
Compare
Mostly want to get the same metrics name with the change to camel case `shuffleService` as that would be a functional break for any current deployments.
ash211
force-pushed
the
resync-to-spark-18364
branch
from
82b08bf to
eb2c71a
Compare
ash211
commented
Mar 28, 2017
| String.class, String.class, MetricsSource.class); | ||
| registerSourceMethod.setAccessible(true); | ||
| registerSourceMethod.invoke(metricsSystem, "shuffleservice", "Metrics on the Spark " + | ||
| registerSourceMethod.invoke(metricsSystem, "shuffleService", "Metrics on the Spark " + |
Author
There was a problem hiding this comment.
mostly because I want to make sure we don't start looking for the wrong casing of this in metrics collectors
Merged
mccheah
pushed a commit
that referenced
this pull request
Apr 27, 2017
* pod-watch progress around watch events * Simplify return * comments
dvogelbacher
pushed a commit
that referenced
this pull request
Jul 30, 2018
* pod-watch progress around watch events * Simplify return * comments (cherry picked from commit d81c084)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly want to get the same metrics name with the change to camel case
shuffleServiceas that would be a functional break for any current deployments.