[BUILD] Set hadoop-palantir profile for publish functions #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robert3005
reviewed
Mar 10, 2021
.circleci/config.yml
Outdated
| @@ -33,6 +33,7 @@ deployable-branches-and-tags: &deployable-branches-and-tags | |||
| only: | |||
| - /palantir-.*/ | |||
| - master | |||
| - wr/fix-publish | |||
There was a problem hiding this comment.
Just to see with a snapshot that this actually fixes the problem. I'll undo this line before merging.
|
ok 👍 |
|
It did fix it! https://pl.ntr/1Vc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a hadoop-palantir profile in our pom.xml, and it adds the modules hadoop-palantir, hadoop-palantir-bom, and hadoop-cloud. Without the profile set, Maven ignores those modules.
In #737, I didn't make sure the profile is set for publishing. As result, e.g., the pom file is missing here.
This should correct that.