Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Trace headers instead of append #350

Merged
merged 2 commits into from
Nov 14, 2019
Merged

Replace Trace headers instead of append #350

merged 2 commits into from
Nov 14, 2019

Conversation

gatesn
Copy link
Contributor

@gatesn gatesn commented Nov 14, 2019

Fixes #349

As per https://github.com/openzipkin/b3-propagation, the trace headers shouldn't contain multiple values.

@gatesn gatesn requested a review from carterkozak November 14, 2019 14:15
@changelog-app
Copy link

changelog-app bot commented Nov 14, 2019 •
edited by gatesn
Loading

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Replace Trace headers instead of appending them.

Check the box to generate changelog(s)

  • Generate changelog entry

@iamdanfox
Copy link
Contributor

Oof that's kinda trippy, thanks @ngates!

@bulldozer-bot bulldozer-bot bot merged commit 88cf98a into develop Nov 14, 2019
@bulldozer-bot bulldozer-bot bot deleted the ngates/replace-headers branch November 14, 2019 14:44
@svc-autorelease
Copy link
Collaborator

Released 3.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamdanfox iamdanfox iamdanfox approved these changes

@carterkozak carterkozak Awaiting requested review from carterkozak

Assignees
No one assigned
Labels
autorelease merge when ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OkHttpTraceInterceptor should replace trace headers, rather than append
3 participants
@gatesn @iamdanfox @svc-autorelease