fix #66: SpanObserver doesn't prevent execution on failure #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An error is logged, and execution will continue, including other SpanObservers registered to the Tracer.
iamdanfox
reviewed
Feb 7, 2019
| @@ -252,7 +250,23 @@ public static synchronized SpanObserver unsubscribe(String name) { | |||
| } | |||
|
|
|||
| private static void computeObserversList() { | |||
| observersList = ImmutableList.copyOf(observers.values()); | |||
| Consumer<Span> newCompositeObserver = span -> { }; | |||
There was a problem hiding this comment.
If we're micro-optimising, why do we tolerate calling the empty observer first and calling andThen on it?
There was a problem hiding this comment.
it's just a method invocation which is free compared to anything that does allocation (list iterator, for example).
There was a problem hiding this comment.
I can get rid of it, but I don't think it's worth the complexity since we won't be able to measure a difference.
iamdanfox
approved these changes
Feb 7, 2019
schlosna
added a commit
to schlosna/tracing-java
that referenced
this pull request
Mar 29, 2019
Additional test coverage for palantir#66 & palantir#67 for when the async observer executor is shutdown.
bulldozer-bot bot
pushed a commit
that referenced
this pull request
Mar 29, 2019
<!-- PR title should start with '[fix]', '[improvement]' or '[break]' if this PR would cause a patch, minor or major SemVer bump. Omit the prefix if this PR doesn't warrant a standalone release. --> ## Before this PR <!-- Describe the problem you encountered with the current state of the world (or link to an issue) and why it's important to fix now. --> There was no unit test coverage for cases where the async observer executor was shutdown before spans completed. ## After this PR <!-- Describe at a high-level why this approach is better. --> Additional test coverage for #66 & #67 for when the async observer executor is shutdown. <!-- Reference any existing GitHub issues, e.g. 'fixes #000' or 'relevant to #000' -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An error is logged, and execution will continue, including other
SpanObservers registered to the Tracer.