Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete deprecated AsyncTracer #753

Merged
merged 4 commits into from
Aug 2, 2021
Merged

Conversation

iamdanfox
Copy link
Contributor

@iamdanfox iamdanfox commented Aug 2, 2021

Before this PR

AsyncTracer was added 2 years ago in this PR #117, but superseded by the DetachedSpan API. An internal sourcegraph search shows no usages.

I'd quite like to prune the unnecessary bits of tracing-java's API as it makes it easier to imagine what it would look like for the internals to use something different (e.g. opentelemetry). Ideally we would have included it in the most recent 5.0.0 release..

After this PR

==COMMIT_MSG==
The deprecated AsyncTracer class is deleted.
==COMMIT_MSG==

Possible downsides?

  • While I can't find any usages of this class in an internal codesearch, it's possible someone is still running an old version of a jar which is compiled and uses this method. In practise, the only usage I know of was c-j-r... and this also cut over to the new DetachedSpan in 2019 Completely revamp tracing spans conjure-java-runtime#1205

@changelog-app
Copy link

changelog-app bot commented Aug 2, 2021

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

The deprecated AsyncTracer class is deleted.

Check the box to generate changelog(s)

  • Generate changelog entry

@policy-bot policy-bot bot requested a review from fawind August 2, 2021 17:47
@@ -0,0 +1,5 @@
type: break
break:
Copy link
Contributor Author

@iamdanfox iamdanfox Aug 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my only other thought about calling this a break and cutting another major rev is would we want to also delete any other deprecated things (like OkhttpTraceInterceptor) perhaps??

or:

@Deprecated
    public static OpenSpan of(String operation, String spanId, SpanType type, Optional<String> parentSpanId) 

also

AsyncSlf4jSpanObserver

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Major revs are cheap, we can dev a few times. If there are other breaks you’d like to make in the same major rev as this one we can merge them around the same time.

@bulldozer-bot bulldozer-bot bot merged commit b00059c into develop Aug 2, 2021
@iamdanfox iamdanfox deleted the dfox/delete-async-tracer branch August 6, 2021 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants