When Tracer.completeSpan() result is unused, prefer fastCompleteSpan #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latter avoids work when operations are not sampled, which is significantly more common than sampling. Added error-prone annotations to validate correct usage.
carterkozak
commented
Mar 1, 2019
| @@ -56,7 +56,7 @@ public Response intercept(Chain chain) throws IOException { | |||
| try { | |||
| response = chain.proceed(tracedRequest.build()); | |||
| } finally { | |||
| Tracer.completeSpan(); | |||
| Tracer.fastCompleteSpan(); | |||
There was a problem hiding this comment.
Only usage change in main sources
iamdanfox
reviewed
Mar 4, 2019
| */ | ||
| @CheckReturnValue |
There was a problem hiding this comment.
👍 this is a pretty neat way of ensuring we don't do unused work :)
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latter avoids work when operations are not sampled, which is
significantly more common than sampling.
Added error-prone annotations to validate correct usage.