Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excavator: Upgrades Baseline to the latest version #1101

Merged
merged 1 commit into from
Jun 3, 2021

Conversation

svc-excavator-bot
Copy link
Collaborator

excavator is a bot for automating changes across repositories.

Changes produced by the roomba/latest-baseline-oss check.

To enable or disable this check, please contact the maintainers of Excavator.

@schlosna
Copy link
Contributor

schlosna commented Jun 3, 2021

@pkoenig10 this seems like a false positive failing on the ImmutablesStyle error-prone check added in palantir/gradle-baseline#1727 on annotations that are not @Value.Style meta annotations:

> Task :tritium-metrics:compileJava FAILED
/home/circleci/project/tritium-metrics/src/main/java/com/palantir/tritium/event/metrics/annotations/MetricGroup.java:30: warning: [ImmutablesStyle] Using an inline Immutables @Value.Style annotation or meta-annotation with non-SOURCE rentention forces consumers to add a Immutables annotations to their compile classpath.Instead use a meta-annotation with SOURCE retention.See https://github.com/immutables/immutables/issues/291.
public @interface MetricGroup {
        ^
    (see https://github.com/palantir/gradle-baseline#baseline-error-prone-checks)
error: warnings found and -Werror specified
1 error
1 warning

@Target({ElementType.METHOD, ElementType.TYPE})
@Retention(RetentionPolicy.RUNTIME)
public @interface MetricGroup {

and also failing at:

@Retention(RetentionPolicy.RUNTIME)
@Target(ElementType.PARAMETER)
@interface MethodIndex {}

@svc-excavator-bot svc-excavator-bot force-pushed the roomba/latest-baseline-oss branch from 0d4063c to 59c415c Compare June 3, 2021 17:16
@bulldozer-bot bulldozer-bot bot merged commit 1cd7edc into develop Jun 3, 2021
@bulldozer-bot bulldozer-bot bot deleted the roomba/latest-baseline-oss branch June 3, 2021 17:19
@schlosna
Copy link
Contributor

schlosna commented Jun 3, 2021

Fixed by palantir/gradle-baseline#1781

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants