Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ThreadFactory tags to differentiate platform and virtual threads #1794

Merged
merged 3 commits into from
Sep 17, 2023
Merged

Add ThreadFactory tags to differentiate platform and virtual threads #1794

merged 3 commits into from
Sep 17, 2023

Conversation

carterkozak
Copy link
Contributor

Note that the total thread count metrics reported by ThreadMXBean only report on platform threads, so they needn't be updated.

==COMMIT_MSG==
Add ThreadFactory tags to differentiate platform and virtual threads
==COMMIT_MSG==

@carterkozak
Add ThreadFactory tags to differentiate platform and virtual threads
b8fea6a 
Note that the total thread count metrics reported by ThreadMXBean
only report on platform threads, so they needn't be updated.
@changelog-app
Copy link

changelog-app bot commented Sep 17, 2023 •
edited by carterkozak
Loading

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Add ThreadFactory tags to differentiate platform and virtual threads

Check the box to generate changelog(s)

  • Generate changelog entry

carterkozak
carterkozak commented Sep 17, 2023
View reviewed changes
tritium-metrics/src/test/java/com/palantir/tritium/metrics/TaggedMetricsThreadFactoryTest.java
}

@Test
void testVirtualThreadInstrumentation() {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests share a fair bit of code. I bias away from sharing functionality between tests because it often results in refactors down the line that reduce the efficacy of some tests. In this case the tests are validating very similar things with different inputs, so there may be a stronger argument for sharing test code

schlosna
schlosna reviewed Sep 17, 2023
View reviewed changes
Copy link
Contributor

@schlosna schlosna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me. One question on skipping virtual thread test on JDK < 21

tritium-metrics/src/test/java/com/palantir/tritium/metrics/TaggedMetricsThreadFactoryTest.java Outdated
Comment on lines 84 to 85
ThreadFactory delegate = VirtualThreads.get()
.orElseThrow(() -> new AssertionError("Expected jdk21+"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we assumeThat(VirtualThreads.get).isPresent() or similar to allow skipping test on JDK < 21?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bulldozer-bot bulldozer-bot bot merged commit e769ff6 into develop Sep 17, 2023
1 check passed
@bulldozer-bot bulldozer-bot bot deleted the ckozak/threads branch September 17, 2023 22:27
@svc-autorelease
Copy link
Collaborator

Released 0.77.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schlosna schlosna schlosna approved these changes

Assignees
No one assigned
Labels
autorelease 🤖 fix nits merge when ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@carterkozak @svc-autorelease @schlosna @svc-changelog