Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excavator: Upgrade to Gradle 8 #1861

Merged
merged 2 commits into from
Feb 7, 2024
Merged

Excavator: Upgrade to Gradle 8 #1861

merged 2 commits into from
Feb 7, 2024

Conversation

svc-excavator-bot
Copy link
Collaborator

excavator is a bot for automating changes across repositories.

Changes produced by the roomba/gradle8-pr check.

To enable or disable this check, please contact the maintainers of Excavator.

@schlosna
Copy link
Contributor

schlosna commented Feb 7, 2024

@CRogers flagging this for SA

The build is failing on metric-schema's generate-metrics task not being compatible with gradle 8, so we probably need to address that & palantir/metric-schema#1089 first.

> Task :tritium-lib:sourcesJar FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Some problems were found with the configuration of task ':tritium-lib:sourcesJar' (type 'Jar').
  - Gradle detected a problem with the following location: '/home/circleci/project/tritium-lib/build/metricSchema/generated_src'.
    
    Reason: Task ':tritium-lib:sourcesJar' uses this output of task ':tritium-lib:generateMetrics' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed.
    
    Possible solutions:
      1. Declare task ':tritium-lib:generateMetrics' as an input of ':tritium-lib:sourcesJar'.
      2. Declare an explicit dependency on ':tritium-lib:generateMetrics' from ':tritium-lib:sourcesJar' using Task#dependsOn.
      3. Declare an explicit dependency on ':tritium-lib:generateMetrics' from ':tritium-lib:sourcesJar' using Task#mustRunAfter.
    
    For more information, please refer to https://docs.gradle.org/8.5/userguide/validation_problems.html#implicit_dependency in the Gradle documentation.
  - Gradle detected a problem with the following location: '/home/circleci/project/tritium-lib/build/metricSchema'.
    
    Reason: Task ':tritium-lib:sourcesJar' uses this output of task ':tritium-lib:compileMetricSchema' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed.
    
    Possible solutions:
      1. Declare task ':tritium-lib:compileMetricSchema' as an input of ':tritium-lib:sourcesJar'.
      2. Declare an explicit dependency on ':tritium-lib:compileMetricSchema' from ':tritium-lib:sourcesJar' using Task#dependsOn.
      3. Declare an explicit dependency on ':tritium-lib:compileMetricSchema' from ':tritium-lib:sourcesJar' using Task#mustRunAfter.
    
    For more information, please refer to https://docs.gradle.org/8.5/userguide/validation_problems.html#implicit_dependency in the Gradle documentation.

tasks.sourcesJar.dependsOn(generateMetrics)
tasks.sourcesJar.dependsOn(compileMetricSchema)
Comment on lines +4 to +6
// work around metric-schema gradle 8 task dependency
tasks.sourcesJar.dependsOn(generateMetrics)
tasks.sourcesJar.dependsOn(compileMetricSchema)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created palantir/metric-schema#1092 to remove need for this

@bulldozer-bot bulldozer-bot bot merged commit 98d3c0d into develop Feb 7, 2024
5 checks passed
@bulldozer-bot bulldozer-bot bot deleted the roomba/gradle8-pr branch February 7, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants