Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The cache.stats.disabled metric is listed in metric-schema #2005

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

carterkozak
Copy link
Contributor

@carterkozak carterkozak commented Aug 29, 2024

This commit changes the type from counter to meter -- the recorded result should be the same, however meters can be elided when their value is zero because they cannot decrease, slightly reducing load on our indexing system.
In practice we only created the counters as needed, so this shouldn't change things in practice, but it will retain that safety even if refactored to create the metric object eagerly.

==COMMIT_MSG==
The cache.stats.disabled metric is listed in metric-schema
==COMMIT_MSG==

This commit changes the type from counter to meter -- the recorded
result should be the same, however meters can be elided when their
value is zero because they cannot decrease, slightly reducing load
on our indexing system.
@changelog-app
Copy link

changelog-app bot commented Aug 29, 2024

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

The cache.stats.disabled metric is listed in metric-schema

Check the box to generate changelog(s)

  • Generate changelog entry

Copy link
Contributor

@schlosna schlosna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @carterkozak !

@bulldozer-bot bulldozer-bot bot merged commit d27bf86 into develop Aug 29, 2024
5 checks passed
@bulldozer-bot bulldozer-bot bot deleted the ckozak/report_stats_disabled_metric_schema branch August 29, 2024 22:29
@autorelease3
Copy link

autorelease3 bot commented Aug 29, 2024

Released 0.91.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants