Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove findbugs #76

Merged
merged 4 commits into from
May 4, 2018
Merged

Remove findbugs #76

merged 4 commits into from
May 4, 2018

Conversation

iamdanfox
Copy link
Contributor

The findbugs plugin was removed from baseline in March 2017 (palantir/gradle-baseline#131), so this repo contains many (unvalidated) findbugs annotations.

These would be mostly harmless, except that they cause a new com.palantir.baseline-class-uniqueness plugin to fail: the findbugs jars are notoriously unhygienic. jsr305, annotations and findbugs-annotations all define some classes with the same name.

Rather than just ignoring these violations, I figured we might as well fix them at the source :)

@schlosna schlosna merged commit 92564a5 into develop May 4, 2018
@schlosna schlosna deleted the remove-findbugs branch May 4, 2018 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants