New rule: jsx-prefer-fragment (#147) #161
Conversation
|
Thanks for your interest in palantir/tslint-react, @banyan! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
banyan
force-pushed
the
banyan-jsx-prefer-fragment
branch
from
e5f56f5
to
35c11bd
Compare
There was a problem hiding this comment.
I'm concerned about the generalizability of this rule as well, as per #147 (comment)
I feel like you'd end up with a bunch of tslint:disable statements in random places, and it will be hard for devs to understand why some wrappers are fragments and some are divs. encoding this logic into a lint rule makes it worse because an inexperienced dev will be coerced into thinking that fragments are always better. have you tried this rule on any sizable codebase?
| function render(){ | ||
| return( | ||
| <div> | ||
| ~~~ [An empty 'div' should be written as React.Fragment.] |
There was a problem hiding this comment.
this is not an empty div, it's a plain div without any attributes set
|
Closing due to inactivity and age. See #210 |
Fixes #147.