Merge pull request #419 from adidahiya/destructuring-no-unused-imports

enhance import syntax tests for no-unused-variable rule
palantir · Jun 2, 2015 · 0aa7114 · 0aa7114
2 parents 195de46 + 9a86b95
commit 0aa7114
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/test/files/rules/nounusedvariable-imports.test.ts b/test/files/rules/nounusedvariable-imports.test.ts
@@ -11,7 +11,14 @@ $(_.xyz());
 /// <reference path="../externalFormatter.test.ts" />
 
 module S {
- var template = '';
+ var template = ""; // failure
 }
 
-import * as foo from "lib";
+import * as foo from "libA"; // failure on 'foo'
+import * as bar from "libB";
+import baz from "libC";
+import defaultExport, { namedExport } from "libD"; // failure on 'defaultExport'
+
+bar.someFunc();
+baz();
+namedExport();
diff --git a/test/rules/noUnusedVariableRuleTests.ts b/test/rules/noUnusedVariableRuleTests.ts
@@ -22,13 +22,15 @@ describe("<no-unused-variable>", () => {
  var failure2 = Lint.Test.createFailuresOnFile(fileName, Rule.FAILURE_STRING + "'createReadStream'")([4, 9], [4, 25]);
  var failure3 = Lint.Test.createFailuresOnFile(fileName, Rule.FAILURE_STRING + "'template'")([14, 7], [14, 15]);
  var failure4 = Lint.Test.createFailuresOnFile(fileName, Rule.FAILURE_STRING + "'foo'")([17, 13], [17, 16]);
+ var failure5 = Lint.Test.createFailuresOnFile(fileName, Rule.FAILURE_STRING + "'defaultExport'")([20, 8], [20, 21]);
  var actualFailures = Lint.Test.applyRuleOnFile(fileName, Rule);
 
- assert.lengthOf(actualFailures, 4);
+ assert.lengthOf(actualFailures, 5);
  Lint.Test.assertContainsFailure(actualFailures, failure1);
  Lint.Test.assertContainsFailure(actualFailures, failure2);
  Lint.Test.assertContainsFailure(actualFailures, failure3);
  Lint.Test.assertContainsFailure(actualFailures, failure4);
+ Lint.Test.assertContainsFailure(actualFailures, failure5);
  });
 
  it("restricts unused variables", () => {