Fix multiple --exclude arguments (#2858)

palantir · Jun 1, 2017 · 1d8d928 · 1d8d928
1 parent b9c62b1
commit 1d8d928
Show file tree

Hide file tree

Showing 6 changed files with 45 additions and 4 deletions.
diff --git a/src/tslint-cli.ts b/src/tslint-cli.ts
@@ -45,7 +45,7 @@ interface Option {
     short?: string;
     // Commander will camelCase option names.
     name: keyof Argv | "rules-dir" | "formatters-dir" | "type-check";
-    type: "string" | "boolean";
+    type: "string" | "boolean" | "array";
     describe: string; // Short, used for usage message
     description: string; // Long, used for `--help`
 }
@@ -74,7 +74,7 @@ const options: Option[] = [
     {
         short: "e",
         name: "exclude",
-        type: "string",
+        type: "array",
         describe: "exclude globs from path expansion",
         description: dedent`
             A filename or glob which indicates files to exclude from linting.
@@ -187,9 +187,18 @@ const options: Option[] = [
     },
 ];
 
+function collect(val: string, memo: string[]) {
+    memo.push(val);
+    return memo;
+}
+
 for (const option of options) {
-    const commanderStr = optionUsageTag(option) + (option.type === "string" ? ` [${option.name}]` : "");
-    commander.option(commanderStr, option.describe);
+    const commanderStr = optionUsageTag(option) + optionParam(option);
+    if (option.type === "array") {
+        commander.option(commanderStr, option.describe, collect, []);
+    } else {
+        commander.option(commanderStr, option.describe);
+    }
 }
 
 commander.on("--help", () => {
@@ -249,3 +258,14 @@ run({
 function optionUsageTag({short, name}: Option) {
     return short !== undefined ? `-${short}, --${name}` : `--${name}`;
 }
+
+function optionParam(option: Option) {
+    switch (option.type) {
+        case "string":
+            return ` [${option.name}]`;
+        case "array":
+            return ` <${option.name}>`;
+        case "boolean":
+            return "";
+    }
+}
diff --git a/test/executable/executableTests.ts b/test/executable/executableTests.ts
@@ -348,6 +348,19 @@ describe("Executable", function(this: Mocha.ISuiteCallbackContext) {
                     done();
                 });
         });
+
+        it("can handle multiple '--exclude' globs", (done) => {
+            execCli(
+                [
+                    "-c", "test/files/multiple-excludes/tslint.json",
+                    "--exclude", "'test/files/multiple-excludes/invalid.test.ts'",
+                    "--exclude", "'test/files/multiple-excludes/invalid2*'",
+                    "'test/files/multiple-excludes/**.ts'",
+                ], (err) => {
+                    assert.isNull(err, "process should exit without an error");
+                    done();
+                });
+        });
     });
 
     describe("--type-check", () => {

diff --git a/test/files/multiple-excludes/invalid.test.ts b/test/files/multiple-excludes/invalid.test.ts
@@ -0,0 +1 @@
+var foo = 42
diff --git a/test/files/multiple-excludes/invalid2.test.ts b/test/files/multiple-excludes/invalid2.test.ts
@@ -0,0 +1 @@
+module.exports = {}
diff --git a/test/files/multiple-excludes/tslint.json b/test/files/multiple-excludes/tslint.json
@@ -0,0 +1,5 @@
+{
+    "rules": {
+        "semicolon": [true, "always"]
+    }
+}
diff --git a/test/files/multiple-excludes/valid.test.ts b/test/files/multiple-excludes/valid.test.ts
@@ -0,0 +1 @@
+var foo = 42;