prefer-function-over-method should ignore abstract methods (#2307)

Abstract methods have no body, and never use `this`, so the `prefer-function-over-method` rule should not apply to them.
palantir · Mar 7, 2017 · 5661bfb · 5661bfb
1 parent 3923abf
commit 5661bfb
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/rules/preferFunctionOverMethodRule.ts b/src/rules/preferFunctionOverMethodRule.ts
@@ -99,7 +99,7 @@ class PreferFunctionOverMethodWalker extends Lint.RuleWalker {
     }
 
     private shouldWarnForModifiers(node: ts.MethodDeclaration): boolean {
-        if (Lint.hasModifier(node.modifiers, ts.SyntaxKind.StaticKeyword)) {
+        if (Lint.hasModifier(node.modifiers, ts.SyntaxKind.StaticKeyword, ts.SyntaxKind.AbstractKeyword)) {
             return false;
         }
         // TODO: Also return false if it's marked "override" (https://github.com/palantir/tslint/pull/2037)

diff --git a/test/rules/prefer-function-over-method/default/test.ts.lint b/test/rules/prefer-function-over-method/default/test.ts.lint
@@ -44,6 +44,10 @@ class C {
     ~~~~~~~~~~~~~~~~~ [0]
 }
 
+abstract class C2 {
+    abstract abstract(): void;
+}
+
 const o = {
     x() {}
 }