Update tslint devDependency (#3437)

and try to get rid of some disable comments

package.json

@@ -74,7 +74,7 @@
  "nyc": "^10.2.0",
  "rimraf": "^2.5.4",
  "ts-node": "^3.3.0",
- "tslint": "^5.7.0",
+ "tslint": "^5.8.0",
  "tslint-test-config-non-relative": "file:test/external/tslint-test-config-non-relative",
  "typescript": "~2.6.1"
  },

src/rules/noInvalidTemplateStringsRule.ts

@@ -24,8 +24,7 @@ export class Rule extends Lint.Rules.AbstractRule {
  /* tslint:disable:object-literal-sort-keys */
  public static metadata: Lint.IRuleMetadata = {
  ruleName: "no-invalid-template-strings",
- // tslint:disable-next-line no-invalid-template-strings
- description: "Warns on use of `${` in non-template strings.",
+ description: "Warns on use of `\${` in non-template strings.",
  optionsDescription: "Not configurable.",
  options: null,
  optionExamples: [true],

src/rules/noUnusedVariableRule.ts

@@ -413,7 +413,7 @@ function makeUnusedCheckedProgram(program: ts.Program, checkParameters: boolean)
  readFile: (f) => sourceFilesByName.get(getCanonicalFileName(f))!.text,
  getSourceFile: (f) => sourceFilesByName.get(getCanonicalFileName(f))!,
  getDefaultLibFileName: () => ts.getDefaultLibFileName(options),
- writeFile: () => {}, // tslint:disable-line no-empty
+ writeFile: () => undefined,
  getCurrentDirectory: () => "",
  getDirectories: () => [],
  getCanonicalFileName,

yarn.lock

@@ -339,10 +339,6 @@ color-name@^1.1.1:
  version "1.1.3"
  resolved "https://registry.yarnpkg.com/color-name/-/color-name-1.1.3.tgz#a7d0558bd89c42f795dd42328f740831ca53bc25"
 
-colors@^1.1.2:
- version "1.1.2"
- resolved "https://registry.yarnpkg.com/colors/-/colors-1.1.2.tgz#168a4701756b6a7f51a12ce0c97bfa28c084ed63"
-
 commander@2.9.0, commander@^2.9.0:
  version "2.9.0"
  resolved "https://registry.yarnpkg.com/commander/-/commander-2.9.0.tgz#9c99094176e12240cb22d6c5146098400fe0f7d4"
@@ -1577,33 +1573,28 @@ tslib@^1.8.0:
 "tslint-test-config-non-relative@file:test/external/tslint-test-config-non-relative":
  version "0.0.1"
 
-tslint@^5.7.0:
- version "5.7.0"
- resolved "https://registry.yarnpkg.com/tslint/-/tslint-5.7.0.tgz#c25e0d0c92fa1201c2bc30e844e08e682b4f3552"
+tslint@^5.8.0:
+ version "5.8.0"
+ resolved "https://registry.yarnpkg.com/tslint/-/tslint-5.8.0.tgz#1f49ad5b2e77c76c3af4ddcae552ae4e3612eb13"
  dependencies:
  babel-code-frame "^6.22.0"
- colors "^1.1.2"
+ builtin-modules "^1.1.1"
+ chalk "^2.1.0"
  commander "^2.9.0"
  diff "^3.2.0"
  glob "^7.1.1"
  minimatch "^3.0.4"
  resolve "^1.3.2"
  semver "^5.3.0"
  tslib "^1.7.1"
- tsutils "^2.8.1"
+ tsutils "^2.12.1"
 
 tsutils@^2.12.1:
  version "2.12.1"
  resolved "https://registry.yarnpkg.com/tsutils/-/tsutils-2.12.1.tgz#f4d95ce3391c8971e46e54c4cf0edb0a21dd5b24"
  dependencies:
  tslib "^1.7.1"
 
-tsutils@^2.8.1:
- version "2.10.0"
- resolved "https://registry.yarnpkg.com/tsutils/-/tsutils-2.10.0.tgz#ae94511df2656eb06e4424056fba5c388887040c"
- dependencies:
- tslib "^1.7.1"
-
 type-detect@0.1.1:
  version "0.1.1"
  resolved "https://registry.yarnpkg.com/type-detect/-/type-detect-0.1.1.tgz#0ba5ec2a885640e470ea4e8505971900dac58822"