Fix no-unnecessary-qualifier handling of implicit arguments (#2555)

palantir · Apr 12, 2017 · 6f1f1ad · 6f1f1ad
1 parent 8c7644a
commit 6f1f1ad
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/src/rules/noUnnecessaryQualifierRule.ts b/src/rules/noUnnecessaryQualifierRule.ts
@@ -114,9 +114,13 @@ class Walker extends Lint.ProgramAwareRuleWalker {
     }
 
     private symbolIsNamespaceInScope(symbol: ts.Symbol): boolean {
-        if (symbol.getDeclarations().some((decl) => this.namespacesInScope.some((ns) => ns === decl))) {
+        const symbolDeclarations = symbol.getDeclarations();
+        if (symbolDeclarations == null) {
+            return false;
+        } else if (symbolDeclarations.some((decl) => this.namespacesInScope.some((ns) => ns === decl))) {
             return true;
         }
+
         const alias = this.tryGetAliasedSymbol(symbol);
         return alias !== undefined && this.symbolIsNamespaceInScope(alias);
     }

diff --git a/test/rules/no-unnecessary-qualifier/arguments.ts.lint b/test/rules/no-unnecessary-qualifier/arguments.ts.lint
@@ -0,0 +1,12 @@
+namespace N {
+    export type T = number;
+    export const x: N.T = 0;
+                    ~ [N]
+    export function f() {
+      if (arguments.length > 0) {
+        console.log('arguments should not break this rule');
+      }
+    }
+}
+
+[N]: Qualifier is unnecessary since 'N' is in scope.