fix tsc rule errors for fallthrough

palantir · Mar 28, 2017 · cd66e7c · cd66e7c
1 parent 3c42895
commit cd66e7c
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/src/rules/noInferrableTypesRule.ts b/src/rules/noInferrableTypesRule.ts
@@ -89,7 +89,8 @@ class NoInferrableTypesWalker extends Lint.AbstractWalker<IOptions> {
                         hasModifier(node.modifiers, ts.SyntaxKind.ReadonlyKeyword)) {
                         break;
                     }
-                    /* falls through*/
+                    this.checkDeclaration(node as ts.VariableLikeDeclaration);
+                    break;
                 case ts.SyntaxKind.VariableDeclaration:
                     this.checkDeclaration(node as ts.VariableLikeDeclaration);
             }

diff --git a/src/rules/noUnnecessaryQualifierRule.ts b/src/rules/noUnnecessaryQualifierRule.ts
@@ -72,7 +72,8 @@ class Walker extends Lint.ProgramAwareRuleWalker {
                     this.visitNamespaceAccess(node, expression, name);
                     break;
                 }
-                // falls through
+                super.visitNode(node);
+                break;
             default:
                 super.visitNode(node);
         }

diff --git a/src/rules/trailingCommaRule.ts b/src/rules/trailingCommaRule.ts
@@ -98,7 +98,8 @@ class TrailingCommaWalker extends Lint.AbstractWalker<Options> {
                     if ((node as ts.NewExpression).arguments === undefined) {
                         break;
                     }
-                    // falls through
+                    this.checkList((node as ts.CallExpression | ts.NewExpression).arguments!, node.end);
+                    break;
                 case ts.SyntaxKind.CallExpression:
                     this.checkList((node as ts.CallExpression | ts.NewExpression).arguments!, node.end);
                     break;