binary-expression-operand-order: Allow both sides to be literals (#2873)

palantir · Jun 5, 2017 · df7594b · df7594b
1 parent a88462d
commit df7594b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/rules/binaryExpressionOperandOrderRule.ts b/src/rules/binaryExpressionOperandOrderRule.ts
@@ -45,7 +45,7 @@ export class Rule extends Lint.Rules.AbstractRule {
 
 function walk(ctx: Lint.WalkContext<void>): void {
     ts.forEachChild(ctx.sourceFile, function cb(node) {
-        if (isBinaryExpression(node) && isLiteral(node.left) && !isAllowedOrderedOperator(node)) {
+        if (isBinaryExpression(node) && isLiteral(node.left) && !isLiteral(node.right) && !isAllowedOrderedOperator(node)) {
             ctx.addFailureAtNode(node, Rule.FAILURE_STRING);
         }
         ts.forEachChild(node, cb);

diff --git a/test/rules/binary-expression-operand-order/test.ts.lint b/test/rules/binary-expression-operand-order/test.ts.lint
@@ -36,4 +36,10 @@ undefined != x;
 "key" in x;
 "foo", x;
 
+// Allows literals on both sides.
+1 + 1;
+1 + 1 + 1;
+1 + x + 1;
+~~~~~ [0]
+
 [0]: Literal expression should be on the right-hand side of a binary expression.