Coalesce test cases

- Combine test cases for 'bad' for loops and case for 'good' for loops - Remove unneeded files - Add comments to test cases
palantir · May 3, 2018 · eebadbc · eebadbc
1 parent 596f532
commit eebadbc
Show file tree

Hide file tree

Showing 10 changed files with 30 additions and 27 deletions.
diff --git a/test/rules/prefer-while/bad-no-condition/test.ts.fix b/test/rules/prefer-while/bad-no-condition/test.ts.fix
diff --git a/test/rules/prefer-while/bad-no-condition/test.ts.lint b/test/rules/prefer-while/bad-no-condition/test.ts.lint
diff --git a/test/rules/prefer-while/bad-with-condition/test.ts.fix b/test/rules/prefer-while/bad-with-condition/test.ts.fix
diff --git a/test/rules/prefer-while/bad-with-condition/test.ts.lint b/test/rules/prefer-while/bad-with-condition/test.ts.lint
diff --git a/test/rules/prefer-while/bad-with-condition/tslint.json b/test/rules/prefer-while/bad-with-condition/tslint.json
diff --git a/test/rules/prefer-while/good/test.ts.lint b/test/rules/prefer-while/good/test.ts.lint
diff --git a/test/rules/prefer-while/good/tslint.json b/test/rules/prefer-while/good/tslint.json
diff --git a/test/rules/prefer-while/test.ts.fix b/test/rules/prefer-while/test.ts.fix
@@ -0,0 +1,14 @@
+// for loops without an initializer, termination condition, and incrementor should be updated
+while (true) {
+    console.log(x);
+}
+
+// for loops without an initializer and incrementor should be updated
+while (true===true) {
+    console.log(x);
+}
+
+// for loops with an initializer, termination condition, and incrementor should remain untouched
+for(let x = 1; x < 10; x++) {
+    console.log(x);
+}
diff --git a/test/rules/prefer-while/test.ts.lint b/test/rules/prefer-while/test.ts.lint
@@ -0,0 +1,16 @@
+// for loops without an initializer, termination condition, and incrementor should be updated
+for(;;) {
+~~~~~~~   [Prefer `while` loops instead of `for` loops without an initializer and incrementor.]
+    console.log(x);
+}
+
+// for loops without an initializer and incrementor should be updated
+for(;true===true;) {
+~~~~~~~~~~~~~~~~~~   [Prefer `while` loops instead of `for` loops without an initializer and incrementor.]
+    console.log(x);
+}
+
+// for loops with an initializer, termination condition, and incrementor should remain untouched
+for(let x = 1; x < 10; x++) {
+    console.log(x);
+}
diff --git a/...prefer-while/bad-no-condition/tslint.json → test/rules/prefer-while/tslint.json b/...prefer-while/bad-no-condition/tslint.json → test/rules/prefer-while/tslint.json