This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
prefer-function-over-method should ignore abstract methods
#2307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`prefer-function-over-method` should ignore abstract methods. In this commit, the new test case fails.
Abstract methods have no body, and never use `this`, so the `prefer-function-over-method` rule should not apply to them.
|
Thanks for your interest in palantir/tslint, @sbj42! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
nchen63
approved these changes
Mar 7, 2017
|
@sbj42 thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
prefer-function-over-methodshould ignore abstract methods #2305Overview of change:
The
prefer-function-over-methodrule was warning for abstract methods. This change adds a test case for that, and resolves it. The rule already checks for thestaticmodifier, so it was simple enough to also check for theabstractmodifier.CHANGELOG.md entry:
[bugfix]
prefer-function-over-methodnow ignores abstract methods