This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Rewrite no-duplicate-variable #2354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-hanson
force-pushed
the
no-duplicate-variable
branch
from
4dd9721
to
c5d72c8
Compare
ajafff
reviewed
Mar 24, 2017
src/rules/noDuplicateVariableRule.ts
Outdated
| forEachBoundIdentifier(e.name, action); | ||
| } | ||
| break; | ||
| case ts.SyntaxKind.ArrayBindingPattern: |
There was a problem hiding this comment.
you can make this case clause the default clause and handle both binding patterns to avoid duplicated code since both blocks are very similar. you can then drop the case ObjectBindingPattern
src/rules/noDuplicateVariableRule.ts
Outdated
| if (utils.isVariableDeclaration(node) && !utils.isBlockScopedVariableDeclaration(node)) { | ||
| const scope = scopes[scopes.length - 1]; | ||
| forEachBoundIdentifier(node.name, (id) => { | ||
| const { text } = id; |
There was a problem hiding this comment.
destructure the parameter directly
({text}) => { ... }There was a problem hiding this comment.
It's jused as a node below.
src/rules/noDuplicateVariableRule.ts
Outdated
| const scopes: Array<Set<string>> = [new Set()]; | ||
| return ts.forEachChild(ctx.sourceFile, function cb(node: ts.Node): void { | ||
| if (utils.isFunctionScopeBoundary(node)) { | ||
| scopes.push(new Set()); |
There was a problem hiding this comment.
you don't need a stack. just replace scopes with scope. Save it in a variable here, assign the new Scope and restore it 2 lines below.
|
There's a comment in the tests saying that parameters should be handled by |
ajafff
approved these changes
Mar 28, 2017
adidahiya
approved these changes
Mar 29, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
Just refactored the implementation.