Using (Block/)ScopeAwareRuleWalker with typed programs

[JoshuaKGoldberg]

I don't see any examples of creating a ScopeAwareRuleWalker with a typed rule. Is this intended to be doable?

There could be TypedScopeAwareRuleWalker + TypedBlockScopeAwareRuleWalker, but it feels wrong to make a cross-matrix of all the potential rule types against each other.

[ajafff]

You can just override the constructor, pass the type checker as argument and save it in a property. That's the whole magic `ProgramAwareRuleWalker` does Am 06.04.2017 22:12 schrieb "Josh Goldberg" <notifications@github.com>:

…

I don't see any examples of creating a ScopeAwareRuleWalker with a typed rule. Is this intended to be doable? There could be TypedScopeAwareRuleWalker + TypedBlockScopeAwareRuleWalker, but it feels wrong to make a cross-matrix of all the potential rule types against each other. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#2514>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ALaeKFOA50bVR5MEqbDFKFCL2_DMrPMwks5rtUdIgaJpZM4M2G_T> .

[JoshuaKGoldberg]

This is true, but then for the first createScope call it won't have access to the type checker. Overriding a constructor also feels dirty.

[andy-hanson]

These classes should really not be used. In every example I have seen (except for no-duplicate-variable) they were just used to maintain some context, and the actual rule had nothing to do with scopes. It's better to just use ts.forEachChild and use local variables to store context.
See #2348, #2354, #2372, #2339, #2341, #2346, which combined would eliminate our uses of these two classes.

[JoshuaKGoldberg]

Should they be deprecated then?