Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Fix no-unnecessary-qualifier handling of implicit arguments #2555

Conversation

GoodForOneFare
Copy link
Contributor

PR checklist

  • Addresses an existing issue: #0000
  • New feature, bugfix, or enhancement
    • Includes tests
  • Documentation update

Overview of change:

Symbol#getDeclarations returns null when it's describing an arguments reference. This change short-circuits symbolIsNamespaceInScope if declarations are null.

Is there anything you'd like reviewers to focus on?

Nope.

CHANGELOG.md entry:

[bugfix] no-unnecessary-qualifier: no longer breaks when walking a function that references arguments

@adidahiya adidahiya merged commit 6f1f1ad into palantir:master Apr 12, 2017
@adidahiya
Copy link
Contributor

thanks @GoodForOneFare!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants