Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Fix --project with --exclude #2853

Merged
merged 2 commits into from
Jun 1, 2017
Merged

Fix --project with --exclude #2853

merged 2 commits into from
Jun 1, 2017

Conversation

ajafff
Copy link
Contributor

@ajafff ajafff commented Jun 1, 2017

PR checklist

Overview of change:

[bugfix] Fixed --project used together with --exclude.
Fixes: #2852

Hopefully this works like the previous implementation.

Is there anything you'd like reviewers to focus on?

CHANGELOG.md entry:

Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding a test case!

@sandersn
Copy link
Contributor

sandersn commented Jun 1, 2017

I'm still seeing a failure in cases that don't use --project:

node node_modules/tslint/bin/tslint Gulpfile.ts 'scripts/tslint/*.ts' 'src/**/*.ts' --exclude src/lib/es5.d.ts --exclude 'src/lib/*.generated.d.ts' --format stylish

(For linting Typescript.)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Since 5.4.0 --exclude does not work anymore
3 participants