Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Fix multiple --exclude arguments #2858

Merged
merged 3 commits into from
Jun 1, 2017
Merged

Fix multiple --exclude arguments #2858

merged 3 commits into from
Jun 1, 2017

Conversation

ajafff
Copy link
Contributor

@ajafff ajafff commented Jun 1, 2017

PR checklist

  • Addresses an existing issue: #0000
  • New feature, bugfix, or enhancement
    • Includes tests
  • Documentation update

Overview of change:

Collect all --exclude options.
Fixes: #2855
Fixes: #2856
Fixes: #2855

Is there anything you'd like reviewers to focus on?

There are no test included, because I'm in a hurry right now.

CHANGELOG.md entry:

@sandersn
Copy link
Contributor

sandersn commented Jun 1, 2017

I don't know commander -- does this still treat multiple --exclude arguments as an array? Or does it change the syntax to something like --exclude "prefix/path1/*,prefix/path2/*" ?

@ajafff
Copy link
Contributor Author

ajafff commented Jun 1, 2017 via email

@adidahiya
Copy link
Contributor

I added a test case, this fix seems to work

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xxx.d.ts files aren't being excluded Only the last --exclude is honoured in 5.4.1
3 participants