Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Freeze commander.js package version #3509

Closed
timocov opened this issue Nov 23, 2017 · 0 comments
Closed

Freeze commander.js package version #3509

timocov opened this issue Nov 23, 2017 · 0 comments
Milestone
TSLint v5.9

Comments

@timocov
Copy link
Contributor

timocov commented Nov 23, 2017 •
edited
Loading

Today https://github.com/tj/commander.js has been updated to version 2.12.0 which add @types/node as dependencies (not devDependencies) and it broke some web-based projects which used tslint - it has installed @types/node as cross-deps and now we have the following errors (for example):

error TS2322: Type 'Timer' is not assignable to type 'number | null'.
   Type 'Timer' is not assignable to type 'number'.

while using setTimeout.

Related issue tj/commander.js/issues/719
@timocov timocov mentioned this issue Nov 23, 2017
Merged
1 task
adidahiya pushed a commit that referenced this issue Nov 28, 2017
@timocov @adidahiya
Updated version of commander package (#3510)
21aa184 
Fixes #3509
@adidahiya adidahiya added this to the TSLint v5.9 milestone Nov 28, 2017
HyphnKnight pushed a commit to HyphnKnight/tslint that referenced this issue Apr 9, 2018
@timocov @HyphnKnight
Updated version of commander package (palantir#3510)
6c18169 
Fixes palantir#3509
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
TSLint v5.9
Development

No branches or pull requests
2 participants
@adidahiya @timocov