Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Implement ruleTestRunner as mocha tests. #3967

Closed
NaridaL opened this issue Jun 16, 2018 · 4 comments
Closed

Implement ruleTestRunner as mocha tests. #3967

NaridaL opened this issue Jun 16, 2018 · 4 comments

Comments

@NaridaL
Copy link
Contributor

NaridaL commented Jun 16, 2018

A couple of reasons:

  • Outputting a diff on errors is non-trivial and should be handled externally, the current implementation breaks in some cases. Mocha handles this.

mocha output:
image

current impl. output:
image

  • Better integration with existing environments. E.g. WebStorm shows a nice tree view of test runs and allows failed tests to be viewed in an external diff viewer.

  • Currently running a single test requires using the CLI --test param, which isn't intuitive.

I'm willing to implement the change.

@giladgray
Copy link

@NaridaL i'm not convinced we need to bring in mocha to solve this problem (vs simply a better diff solution). we use babel-code-frame for the diffing but maybe we can use it better?

@NaridaL
Copy link
Contributor Author

NaridaL commented Jun 18, 2018

Yeah just for the first point it's probably unnecessary. But being able to click "view diff" in WebStorm is amazing :-D

@JoshuaKGoldberg
Copy link
Contributor

💀 It's time! 💀

TSLint is being deprecated and no longer accepting pull requests for major new changes or features. See #4534. 😱

If you'd like to see this change implemented, you have two choices:

  • Recommended: Check if this is available in ESLint + typescript-eslint
  • Not Recommended: Fork TSLint locally 🤷‍♂️

👋 It was a pleasure open sourcing with you!

If you believe this message was posted here in error, please comment so we can re-open the issue!

@JoshuaKGoldberg
Copy link
Contributor

🤖 Beep boop! 👉 TSLint is deprecated 👈 (#4534) and you should switch to typescript-eslint! 🤖

🔒 This issue is being locked to prevent further unnecessary discussions. Thank you! 👋

@palantir palantir locked and limited conversation to collaborators Mar 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants