Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Output +/- on diff so added/removed empty lines are visible. #3973

Merged
merged 1 commit into from
Jun 28, 2018
Merged

Output +/- on diff so added/removed empty lines are visible. #3973

merged 1 commit into from
Jun 28, 2018

Conversation

NaridaL
Copy link
Contributor

@NaridaL NaridaL commented Jun 18, 2018

Minor fix which addresses point #1 of #3967.

Copy link

@giladgray giladgray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yes absolutely!!

@NaridaL
Copy link
Contributor Author

NaridaL commented Jun 18, 2018

wait, don't merge this quite yet XD

@NaridaL
Copy link
Contributor Author

NaridaL commented Jun 18, 2018

Sorry, thought the differ returned individual lines. Should work properly now:

image

@NaridaL
Copy link
Contributor Author

NaridaL commented Jun 18, 2018

image

@NaridaL
Copy link
Contributor Author

NaridaL commented Jun 18, 2018

OK, old node versions didn't seem to like my regex. I hope the logger doesn't expect newlines to be in a specific format though... (\n works fine on my windows so I assume not)

@suchanlee suchanlee merged commit 4a11f95 into palantir:master Jun 28, 2018
pablobirukov pushed a commit to evolution-gaming/tslint that referenced this pull request Jul 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants