variable-name rule should support injecting constructors with angular

[btesser]

The following code makes the variable-name inspection fail, despite the fact it is a valid use case. Any suggestions?

class MyController {
  constructor(ExternalConstructor: IExternalConstructor) {
    var z: IExternal = new ExternalConstructor();
  }
}

[leeavital]

TSLint isn't aware of types, so it doesn't know that ExternalConstructor is being used a constructor. You could write a custom rule that rule that is aware of variables that are used as constructors and allows them to be uppercased.

[Delagen]

constructor(@Inject(Http) http:Http)

[typedef] expected parameter: 'Inject' to have a typedef

[leeavital]

@Delagen this looks like an unrelated bug. Moving this to its own issue.

[leeavital]

#479

[btesser]

Is there any way to specify an argument as a constructor? Maybe by using

function (<Function()=>void>UserConstructor)

Or even

function (UserConstructor: typeof User)

Or some similar syntax. The type definition itself should allow tslint to know it isn't a normal variable

[adidahiya]

We should be able to check in the constructor function block if a variable is used as a constructor, i.e. invoked with new.

Also I think the latest TS language services provide some access to type information, but I haven't looked into it too much yet.

[adidahiya]

I think this request is best now addressed by the pascal-case option for the variable-name rule. The above solutions seem overly complicated compared to that option, so I'm closing this out.