Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

variable-name rule should ignore identifiers which represent constructors #577

Closed
adidahiya opened this issue Aug 18, 2015 · 2 comments
Closed

Comments

@adidahiya
Copy link
Contributor

This will require invoking the type checker. It should address #457.

Proposal

Rule walkers can get a TypeChecker via languageService.getProgram().getTypeChecker(). This object should be saved as a private member of the walker class (similar to what we do for languageService in NoUnusedVariablesWalker).

VariableNameWalker#handleVariableName should check if the given identifier is a constructor and return early if it is.

utils.ts should get a new function called isTypeFlagSet which does something similar to isNodeFlagSet, but for type flags.

@adidahiya
Copy link
Contributor Author

@adidahiya
Copy link
Contributor Author

seems like people are doing fine with pascal case. closing this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants