This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 888
[quotemark: backtick] Incorrectly flags string literals in export line #4588
Milestone
Comments
Here's another example: Code being linted const array: SomeType<string, "hello"> = []
const obj: {
"kebab-case": string
} = {
"kebab-case": "value"
} Actual behavior const array: SomeType<string, "hello"> = []
// ~~~~~~~ [" should be `]
const obj: {
"kebab-case": string
// ~~~~~~~~~~~~ [" should be `]
} = {
"kebab-case": "value"
} Expected behavior const array: SomeType<string, "hello"> = []
const obj: {
"kebab-case": string
} = {
"kebab-case": "value"
// ~~~~~~~ [" should be `]
} Problem summary
|
Actually, I think I got something. PR soon. |
4 tasks
JoshuaKGoldberg
pushed a commit
that referenced
this issue
Mar 31, 2019
This commit fixes the cases where export statements, string literal type as generic type parameter, and string literals in object literal property assignments were incorrectly flagged. This also fixes a small lint error (specifying a type parameter same as default).
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Bug Report
TypeScript code being linted
with
tslint.json
configuration:Actual behavior
The quotes get flagged (and changed to backticks if fix is enabled).
Expected behavior
The quotes should remain as double/single quotes, as typescript/ecma doesn't allow backticks here.
The text was updated successfully, but these errors were encountered: